Skip to content

Pinjie/rebuild pool - #57

Merged
RmSchaffert merged 1 commit into
NVIDIA:mainfrom
xupinjie:pinjie/rebuild_pool
Sep 1, 2026
Merged

Pinjie/rebuild pool#57
RmSchaffert merged 1 commit into
NVIDIA:mainfrom
xupinjie:pinjie/rebuild_pool

Conversation

@xupinjie

@xupinjie xupinjie commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Description

rebuild thread pool

Type of Change

Please select (at least one):

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation / examples / tutorials / demos
  • Supporting functionality change (fix or feature in documentation generation, helper scripts, ...)
  • Refactoring / internal change
  • Other (please describe):

Testing

Checklist for testing:

  • Tests added or updated if/as needed
  • Repository test runner executed: scripts/run_tests.sh

Optionally, add a brief description.

Documentation, Examples, Tutorials, Demos

Checklist for documentation:

  • User-facing documentation updated if/as needed (including API docs)
  • Examples / tutorials / demos updated or added (if relevant)
  • Limitations and constraints documented (if relevant)
  • Performance documented (if relevant)
  • Documentation building successful & checks outlined in the Documentation Checks section of the Contribution Guide are performed

Optionally, add a brief description.

Code Quality

Checklist for dependencies:

  • Dependencies updated in the relevant pyproject.toml if/as needed
  • Code formatted according to the Code Formatting Guide

Optionally, add a brief description.

Related Issues / Context

If applicable, link related issues, discussions etc.


DCO / Sign-Off

Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.

References

For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):

Please also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.

@xupinjie
xupinjie requested a review from RmSchaffert August 9, 2026 12:52
@xupinjie

xupinjie commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator Author

/build

@xupinjie
xupinjie force-pushed the pinjie/rebuild_pool branch from f255400 to d879e98 Compare August 20, 2026 06:52
@xupinjie

Copy link
Copy Markdown
Collaborator Author

/build

@RmSchaffert RmSchaffert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The PR looks good to me.
Setting the review to Comment for now as it also contains the commit corresponding to #56. We can merge after #56 is merged.

@xupinjie
xupinjie force-pushed the pinjie/rebuild_pool branch from d879e98 to 6a43dfa Compare August 31, 2026 15:48
@xupinjie

Copy link
Copy Markdown
Collaborator Author

/build

RmSchaffert
RmSchaffert previously approved these changes Sep 1, 2026
@xupinjie
xupinjie dismissed RmSchaffert’s stale review September 1, 2026 02:35

The merge-base changed after approval.

@xupinjie
xupinjie requested a review from RmSchaffert September 1, 2026 02:44
RmSchaffert
RmSchaffert previously approved these changes Sep 1, 2026
@xupinjie
xupinjie dismissed RmSchaffert’s stale review September 1, 2026 02:45

The merge-base changed after approval.

Signed-off-by: pinjie <pinjiex@nvidia.com>
@xupinjie

xupinjie commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/build

@RmSchaffert
RmSchaffert merged commit 3791096 into NVIDIA:main Sep 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants